Skip to content

Migrate tests from Java Driver to Testkit #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Aug 13, 2021

New features:

  • Temporary:DriverMaxTxRetryTime - configures maximum transaction retry time.

Replaced tests:

  • shouldCloseChannelWhenResetFails -> ChannelErrorHandler.channelInactive (existing unit test)

Migrated tests:

  • shouldRetryReadTransactionUntilFailure -> test_should_fail_when_reading_from_unexpectedly_interrupting_readers_using_tx_function
  • shouldRetryWriteTransactionUntilFailure -> test_should_fail_when_writing_to_unexpectedly_interrupting_writers_using_tx_function
  • useSessionAfterDriverIsClosed -> test_should_fail_when_driver_closed_using_session_run
  • shouldRejectConnectionsToNonNeo4jServers -> test_should_reject_server_using_verify_connectivity_bolt_3x0

New features:
- `Temporary:DriverMaxTxRetryTime` - configures maximum transaction retry time.

Replaced tests:
- shouldCloseChannelWhenResetFails -> ChannelErrorHandler.channelInactive (existing unit test)

Migrated tests:
- shouldRetryReadTransactionUntilFailure -> test_should_fail_when_reading_from_unexpectedly_interrupting_readers_using_tx_function
- shouldRetryWriteTransactionUntilFailure -> test_should_fail_when_writing_to_unexpectedly_interrupting_writers_using_tx_function
- useSessionAfterDriverIsClosed -> test_should_fail_when_driver_closed_using_session_run
@injectives injectives requested a review from gjmwoods August 13, 2021 17:35
@injectives injectives merged commit abbecf6 into neo4j:4.4 Aug 16, 2021
@injectives injectives deleted the feature/migfr branch August 16, 2021 09:01
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Aug 16, 2021
New features:
- `Temporary:DriverMaxTxRetryTime` - configures maximum transaction retry time.

Replaced tests:
- shouldCloseChannelWhenResetFails -> ChannelErrorHandler.channelInactive (existing unit test)

Migrated tests:
- shouldRetryReadTransactionUntilFailure -> test_should_fail_when_reading_from_unexpectedly_interrupting_readers_using_tx_function
- shouldRetryWriteTransactionUntilFailure -> test_should_fail_when_writing_to_unexpectedly_interrupting_writers_using_tx_function
- useSessionAfterDriverIsClosed -> test_should_fail_when_driver_closed_using_session_run
injectives added a commit that referenced this pull request Aug 16, 2021
New features:
- `Temporary:DriverMaxTxRetryTime` - configures maximum transaction retry time.

Replaced tests:
- shouldCloseChannelWhenResetFails -> ChannelErrorHandler.channelInactive (existing unit test)

Migrated tests:
- shouldRetryReadTransactionUntilFailure -> test_should_fail_when_reading_from_unexpectedly_interrupting_readers_using_tx_function
- shouldRetryWriteTransactionUntilFailure -> test_should_fail_when_writing_to_unexpectedly_interrupting_writers_using_tx_function
- useSessionAfterDriverIsClosed -> test_should_fail_when_driver_closed_using_session_run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants