Skip to content

Routing context in URI #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Conversation

lutovich
Copy link
Contributor

@lutovich lutovich commented Mar 29, 2017

Routing context is a map of string key-value pairs. It is send to the database when calling dbms.cluster.routing.getRoutingTable procedure as it's single argument. This is only supported by 3.2+ servers.

Previously routing context was defined on the config. It is problematic because routing context in bolt+routing specific and thus makes no sense for single instance database.

This PR makes routing context part of the bolt+routing URI. It lives in the query part of the URI as regular query parameters like:
bolt+routing://localhost:7687/?policy=my_policy&region=china.

Clustering-specific configuration method is removed.

@lutovich lutovich requested review from technige and zhenlineo March 29, 2017 22:36
@lutovich lutovich force-pushed the 1.3-routing-ctx-uri branch from 93ec4cf to 8caedd8 Compare March 29, 2017 23:06
@lutovich lutovich force-pushed the 1.3-routing-ctx-uri branch from 8caedd8 to 8b15e13 Compare March 31, 2017 13:31
Routing context is a map of string key-value pairs. It is send to the
database when calling `dbms.cluster.routing.getRoutingTable` procedure
as it's single argument. This is only supported by 3.2+ servers.

Previously routing context was defined on the config. It is problematic
because routing context in `bolt+routing` specific and thus makes no
sense for single instance database.

This commit makes routing context part of the `bolt+routing` URI. It
lives in the query part of the URI as regular query parameters like:
`bolt+routing://localhost:7687/?policy=my_policy&region=china`.
Clustering-specific configuration method is removed.
@lutovich lutovich force-pushed the 1.3-routing-ctx-uri branch from 8b15e13 to 559db5a Compare March 31, 2017 13:33
@zhenlineo
Copy link
Contributor

LG, merging

@zhenlineo zhenlineo merged commit 049d45b into neo4j:1.3 Apr 3, 2017
@lutovich lutovich deleted the 1.3-routing-ctx-uri branch April 11, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants