feat(object-mapping): Add support for mapping list value to array #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/arrays
branch
from
9476626 to
85f6189
Compare
injectives
changed the title
injectives
force-pushed
the
feature/arrays
branch
3 times, most recently
from
8340e74 to
1bc0e00
Compare
injectives
changed the title
The main objective of this update is to add support for mapping list value to array. Given that `org.neo4j.driver.Values#value(Object)` method allows creating list value from array (excluding `byte[]`), it makes sense to support the mapping back from list value to array.
Example:
```java
var array = new float[] {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
var values = Values.value(array);
assertArrayEquals(array, values.as(float[].class));
```
As `org.neo4j.driver.Values#value(Object)` supports mapping `char[]` and `short[]` to list values, the supported mappings from string and integer values have also been extended.
Updated list of supported mappings:
- `TypeSystem#LIST` -> `List`, `T[]` as long as list elements may be mapped to the array component type (for example, `char[]`, `boolean[]`, `String[]`, `long[]`, `int[]`, `short[]`, `double[]`, `float[]`)
- `TypeSystem#STRING` -> `String`, `char`, `Character`
- `TypeSystem#INTEGER` -> `long`, `Long`, `int`, `Integer`, `short`, `Short`, `double`, `Double`, `float`, `Float`
injectives
force-pushed
the
feature/arrays
branch
from
1bc0e00 to
1a771b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective of this update is to add support for mapping list value to array. Given that
org.neo4j.driver.Values#value(Object)method allows creating list value from array (excludingbyte[]), it makes sense to support the mapping back from list value to array.Example:
As
org.neo4j.driver.Values#value(Object)supports mappingchar[]andshort[]to list values, the supported mappings from string and integer values have also been extended.Updated list of supported mappings:
TypeSystem#LIST->List,T[]as long as list elements may be mapped to the array component type (for example,char[],boolean[],String[],long[],int[],short[],double[],float[])TypeSystem#STRING->String,char,CharacterTypeSystem#INTEGER->long,Long,int,Integer,short,Short,double,Double,float,Float