Skip to content

chore(NODE-6721): migrate singlebench tests #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2025
Merged

chore(NODE-6721): migrate singlebench tests #4401

merged 3 commits into from
Feb 6, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 6, 2025

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Migrate the single bench to the new format

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6720-multibench branch 2 times, most recently from 415aa0f to 827266c Compare February 6, 2025 16:50
@nbbeeken nbbeeken force-pushed the NODE-6721-single-bench branch 4 times, most recently from 882289b to 50c1f26 Compare February 6, 2025 17:57
@evergreen-ci-prod evergreen-ci-prod bot mentioned this pull request Feb 6, 2025
Merged
5 tasks
@nbbeeken nbbeeken force-pushed the NODE-6720-multibench branch from 827266c to ff73b41 Compare February 6, 2025 18:09
Base automatically changed from NODE-6720-multibench to main February 6, 2025 19:09
@nbbeeken nbbeeken force-pushed the NODE-6721-single-bench branch from 50c1f26 to 7f11fa5 Compare February 6, 2025 19:10
@nbbeeken nbbeeken marked this pull request as ready for review February 6, 2025 19:12
@nbbeeken nbbeeken requested a review from a team as a code owner February 6, 2025 19:12
@W-A-James W-A-James self-assigned this Feb 6, 2025
@W-A-James W-A-James requested review from W-A-James and removed request for a team February 6, 2025 21:09
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 6, 2025
@nbbeeken nbbeeken requested a review from W-A-James February 6, 2025 21:36
@W-A-James W-A-James merged commit 057693e into main Feb 6, 2025
13 of 17 checks passed
@W-A-James W-A-James deleted the NODE-6721-single-bench branch February 6, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @W-A-James