fix: remove catch for synchronous socket errors and remove validation on nodejs option #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Mar 8, 2021
Comment on lines
-250
to
-257
| // Override checkServerIdentity behavior | ||
| if (!options.checkServerIdentity) { | ||
| // Skip the identity check by retuning undefined as per node documents | ||
| // https://nodejs.org/api/tls.html#tls_tls_connect_options_callback | ||
| result.checkServerIdentity = () => undefined; | ||
| } else if (typeof options.checkServerIdentity === 'function') { | ||
| result.checkServerIdentity = options.checkServerIdentity; | ||
| } |
There was a problem hiding this comment.
Seems fine for 4.0, but make sure the documentation reflects this, and that your upgrade notes mention it. The change can't be made for 3.x unfortunately.
mbroadst
approved these changes
Mar 10, 2021
durran
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our validation for a nodejs option suggested that an option could be a boolean when it can actually only be false or a function. In addition this removes the catching of synchronous errors thrown from socket creation.
NODE-3061