This repository was archived by the owner on Oct 30, 2018. It is now read-only.
add omitempty for yml config #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Winkelewski <[email protected]>
justincormack
approved these changes
Jan 4, 2018
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/818?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 3017[6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6] master ijc open "update-component-sha.sh cleanups and fixes."
[|0 ijc: "See the individual commits for details (and smaller, more readable diffs). The n";
384236725 ijc: "I only went so far as to check that `sed -E` was documented in `sed(1)` on mac. ";
384237248 ijc: "Yes, a roundtrip for runc through v0.4 back to acba8886e4b1318457c711700f695a02f";
384237675 deitch: "> back to the start works on mac too.\r\n\r\nExcellent. Thanks @ijc ";
384258535 w9n: "LGTM, nice\r\n\r\n"|]}
{linuxkit/linuxkit 3018[a6e37e0c7ed67c81f2f5cb71611458414dcd549c] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit-ci 10[722a2f45e4e93414ae9af052c31d91c452c1fd98] master samoht open "Add basic support for white-listing tests to run on new PRs."
[|0 samoht: "Currently, the only working option is to say \"test this\" to allow\r\na PR to be te";
307809173 samoht: "/cc @dave-tucker The workflow for testing stuff is very basic atm but it should ";
308124556 samoht: "As suggested by @talex5, I've added the PR check as a separate pipeline step so ";
310026847 dave-tucker: "LGTM and a whitelist file now exists in this repo. Is this good to merge/test?";
310048948 samoht: "It is using unreleased features in datakit-github, so I need to add a few pins i";
310066080 samoht: "I've just fixed the Dockerfile so you should be able to test it more easily."|]}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed
{{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} ci/circleci}
{{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} dco-signed}
{linuxkit/linuxkit 3017}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit heads/master[7b0b7dff84687752594004381325c4b091ee5994]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
Removed
{{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} ci/circleci}
{{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} ci/datakit/linuxkit-ci}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/819?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/819?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/819?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 3018[a6e37e0c7ed67c81f2f5cb71611458414dcd549c] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 3018[a6e37e0c7ed67c81f2f5cb71611458414dcd549c] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit 3018[a6e37e0c7ed67c81f2f5cb71611458414dcd549c] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n";
384386233 lapwat: "Lourd"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/820?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3018[d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n";
384386233 lapwat: "Lourd"|]}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
Removed
{{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} ci/circleci}
{{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} dco-signed}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/820?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 25, 2018
Updated
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3:ci/circleci[failure] url=https://circleci.com/gh/linuxkit/linuxkit/820?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests failed on CircleCI}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 521c875a96f2d205cb49df8ce007a4286b756596:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/821?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 3021[521c875a96f2d205cb49df8ce007a4286b756596] master rn open "Kernel update to 4.16.4/4.16.5/4.14.36/4.14.37/4.9.96/4.4.129 + EOL 4.15.x"
[|0 rn: "Regular kernel updates and EOLing of 4.15.x\r\n\r\nAll kernels compiled for all arch"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 521c875a96f2d205cb49df8ce007a4286b756596}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 521c875a96f2d205cb49df8ce007a4286b756596:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 521c875a96f2d205cb49df8ce007a4286b756596:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/821?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 521c875a96f2d205cb49df8ce007a4286b756596:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/821?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 3021[521c875a96f2d205cb49df8ce007a4286b756596] master rn open "Kernel update to 4.16.4/4.16.5/4.14.36/4.14.37/4.9.96/4.4.129 + EOL 4.15.x"
[|0 rn: "Regular kernel updates and EOLing of 4.15.x\r\n\r\nAll kernels compiled for all arch";
385094225 rn: "CI failure is unrelated:\r\n```\r\n[+ 26m 34s] [STDERR ] 2018-04-27T19:42:50.387938"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3018[d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n";
384386233 lapwat: "Lourd";
385097172 Sh4d1: "@rn yeah it is not finished yet, still a WIP :) I started this PR in order to ge";
385098264 rn: "I'm easy either way. I don't know scaleway at all so have no strong opinion on h";
385099149 Sh4d1: "Yep will do! :)"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/822?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3018[c8b81a6ad068e067192ed9f88f97c0eaab6a923f] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n";
384386233 lapwat: "Lourd";
385097172 Sh4d1: "@rn yeah it is not finished yet, still a WIP :) I started this PR in order to ge";
385098264 rn: "I'm easy either way. I don't know scaleway at all so have no strong opinion on h";
385099149 Sh4d1: "Yep will do! :)"|]}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
Removed
{{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} ci/circleci}
{{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} dco-signed}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/822?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f:ci/circleci[failure] url=https://circleci.com/gh/linuxkit/linuxkit/822?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests failed on CircleCI}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/823?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 3018[7451797b94b05e2074bec9f2a90a02d379ab834f] master Sh4d1 open "[WIP] Add Scaleway provider to linuxkit"
[|0 Sh4d1: "<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n";
384386233 lapwat: "Lourd";
385097172 Sh4d1: "@rn yeah it is not finished yet, still a WIP :) I started this PR in order to ge";
385098264 rn: "I'm easy either way. I don't know scaleway at all so have no strong opinion on h";
385099149 Sh4d1: "Yep will do! :)"|]}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
Removed
{{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} ci/circleci}
{{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} dco-signed}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Apr 27, 2018
Updated
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 2785[b05420c062fe47eb0408f6a7723dd3ec059450cd] master arm64b open "pkg: rngd service support on AArch64"
[|0 arm64b: "Enable the rngd service in case of a real hardware RNG\r\ndevice is available on A";
348095954 arm64b: "@justincormack @ijc @rn, currently we always pass a `virtio-rng` device backed b";
348103830 deitch: "@arm64b I am a bit confused by this. If I understood you correctly, the problem ";
348114174 arm64b: "@deitch Correct. With `virtio-rng`, we fake a RNG device in the guest but it act";
348115099 deitch: "In that case, I don't get how this PR helps. Doesn't this change `pkg/rngd` whic";
348118776 arm64b: "That's different, this PR just uses the entropy from `/dev/hwrng` to feed `/dev/";
348119592 deitch: "Ah, so you are not fixing that issue, but rather intelligently checking if `hwrn";
348121357 arm64b: "> so you are not fixing that issue\r\n\r\nRight, that's another topic, it's my propo";
348122686 deitch: "> So this PR doesn't care about the backend of the /dev/hwrng, it just establish";
348133007 justincormack: "We should not make this code arm64 specific - `/dev/hwrng` is generic and will c";
348133820 justincormack: "@arm64b in the virtual case, the passthrough that `linuxkit` does is not necessa";
348135902 deitch: "> Generally you should use qemu/kvm directly and decide what to pass depending o";
348163881 justincormack: "@deitch I don't think in general you want to pass through hw rng, you probably w";
348167372 deitch: "> you probably want to mix them into host entropy and pass that\r\n\r\nDidn't unders";
348168513 justincormack: "`linuxkit run` is not designed to be the final answer for production, it does no";
348170325 deitch: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348458071 arm64b: "> I am also slightly confused about /dev/hwrng in the case of virtio rng as it s";
348459023 arm64b: "> I always thought rngd's job was to read from a hardware random device (like /d";
348460603 deitch: "> we need a service like rngd to read entropy from /dev/hwrng and feed it into t";
348469735 arm64b: "> Uh, isn't that precisely what I asked?\r\n\r\nAh, so I think your thought is corre";
348871578 arm64b: "Hello @justincormack @ijc @rn and @deitch , I just forced an update of this PR. ";
349522514 arm64b: "Hi Maintainers, I didn't get any feedback for the latest update, so don't know i";
349633602 deitch: "> I didn't get any feedback for the latest update\r\n\r\nMix of everyone either busy";
349641552 deitch: "Took some time to figure out what this is doing. I do have some comments, but th";
349647685 justincormack: "Sorry, been travelling to Kubecon, will try to review soon!";
350649714 arm64b: "/cc Hello @justincormack, I will be in long vacation for the upcoming Christmas "|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
Removed {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 18, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 73dd7b219d239d038567cbd8ee23a2771d270a8a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1185?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 18, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 3205[8dd28e8e92643838c94dce2567f1a1e5166e4726] master alicefr open "Missing s390x in the switch for qemu Dockerfile"
[|0 alicefr: "Signed-off-by: Alice Frosi <[email protected]>\r\n\r\n";
430691195 justincormack: "I think this is only used for the `linuxkit run qemu ...` functionality when qem";
430894361 alicefr: "thanks @justincormack ! If you plan to remove the `-containerized` option than t"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 19, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3208[d3dfdedb0bffa52f86e1d353f320b3ab22fb2490] master justincormack open "Update Authors"
[|0 justincormack: "Signed-off-by: Justin Cormack <[email protected]>\r\n\r\n![4eby8-meow-book-1"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 19, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 19, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 19, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 20, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed
{{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490} ci/circleci}
{{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490} dco-signed}
{linuxkit/linuxkit 3208}
{linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d3dfdedb0bffa52f86e1d353f320b3ab22fb2490}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 20, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit heads/master[2f9528f2781911d9de1f3230d9827835a6330621]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1187?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed
{{linuxkit/linuxkit 73dd7b219d239d038567cbd8ee23a2771d270a8a} ci/circleci}
{{linuxkit/linuxkit 73dd7b219d239d038567cbd8ee23a2771d270a8a} ci/datakit/linuxkit-ci}
{linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 73dd7b219d239d038567cbd8ee23a2771d270a8a}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 20, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1187?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 20, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1187?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1188?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 3210[6cf141011c643ddbdc357d515f1b2c4794b9fff9] master rn open "Kernel update to 4.18.16/4.14.78/4.9.135/4.4.162"
[|0 rn: "Update kernels:\r\n- 4.18.13/4.18.14/4.18.15/4.18.16\r\n- 4.14.75/4.14.76/4.14.77/4."|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1188?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1188?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed
{{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9} ci/circleci}
{{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9} dco-signed}
{linuxkit/linuxkit 3210}
{linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 6cf141011c643ddbdc357d515f1b2c4794b9fff9}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit heads/master[899c24243068c8ba8bfadbe5eda7eb4bb7814f5a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 899c24243068c8ba8bfadbe5eda7eb4bb7814f5a:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1189?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 899c24243068c8ba8bfadbe5eda7eb4bb7814f5a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed
{{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621} ci/circleci}
{{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621} ci/datakit/linuxkit-ci}
{linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 2f9528f2781911d9de1f3230d9827835a6330621}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 899c24243068c8ba8bfadbe5eda7eb4bb7814f5a:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1189?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 21, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 899c24243068c8ba8bfadbe5eda7eb4bb7814f5a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1189?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 26b692d81502dc05779bf94b1fdcfd744ea6e841:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1190?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 26b692d81502dc05779bf94b1fdcfd744ea6e841:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 3211[26b692d81502dc05779bf94b1fdcfd744ea6e841] master rn open "Add 4.19 kernels (and remove 4.18 for arm64 and s390x)"
[|0 rn: "- Add 4.19 kernels for all arches. The kernel config was derived from 4.18 and r"|]}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 26b692d81502dc05779bf94b1fdcfd744ea6e841}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit 26b692d81502dc05779bf94b1fdcfd744ea6e841:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1190?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1191?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3212[cad6cfe92b8468cfcc0c1b7d147b011df14a74a0] master ijc open "containerd v1.2.0"
[|0 ijc: "This is mostly the usual mechanical bump (no code changes needed in LinuxKit) ex"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1191?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1191?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3212[cad6cfe92b8468cfcc0c1b7d147b011df14a74a0] master ijc open "containerd v1.2.0"
[|0 ijc: "This is mostly the usual mechanical bump (no code changes needed in LinuxKit) ex";
433931908 ijc: "I've not run it at all, CI should cover the basics but this being a new minor ve"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3212[cad6cfe92b8468cfcc0c1b7d147b011df14a74a0] master ijc open "containerd v1.2.0"
[|0 ijc: "This is mostly the usual mechanical bump (no code changes needed in LinuxKit) ex";
433931908 ijc: "I've not run it at all, CI should cover the basics but this being a new minor ve";
433981754 ijc: "CI:\r\n```\r\n[FAIL ] linuxkit.packages.getty-containerd 90.49s\r\n```\r\nNot exactly";
433982062 ijc: "I've kicked CI to have another go while I dig into it, on the off chance it was "|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3212[cad6cfe92b8468cfcc0c1b7d147b011df14a74a0] master ijc open "containerd v1.2.0"
[|0 ijc: "This is mostly the usual mechanical bump (no code changes needed in LinuxKit) ex";
433931908 ijc: "I've not run it at all, CI should cover the basics but this being a new minor ve";
433981754 ijc: "CI:\r\n```\r\n[FAIL ] linuxkit.packages.getty-containerd 90.49s\r\n```\r\nNot exactly";
433982062 ijc: "I've kicked CI to have another go while I dig into it, on the off chance it was ";
433992929 ijc: "Failed for me locally too, so not a flake. Trying to obtain any useful logs.\r\n"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit d9b4723da6d2fdb438ffb0bf6bfb0c6dd184cc6b:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1192?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 3212[d9b4723da6d2fdb438ffb0bf6bfb0c6dd184cc6b] master ijc open "containerd v1.2.0"
[|0 ijc: "This is mostly the usual mechanical bump (no code changes needed in LinuxKit) ex";
433931908 ijc: "I've not run it at all, CI should cover the basics but this being a new minor ve";
433981754 ijc: "CI:\r\n```\r\n[FAIL ] linuxkit.packages.getty-containerd 90.49s\r\n```\r\nNot exactly";
433982062 ijc: "I've kicked CI to have another go while I dig into it, on the off chance it was ";
433992929 ijc: "Failed for me locally too, so not a flake. Trying to obtain any useful logs.\r\n"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit d9b4723da6d2fdb438ffb0bf6bfb0c6dd184cc6b}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed
{{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0} ci/circleci}
{{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0} ci/datakit/linuxkit-ci}
{{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0} dco-signed}
{linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit cad6cfe92b8468cfcc0c1b7d147b011df14a74a0}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit d9b4723da6d2fdb438ffb0bf6bfb0c6dd184cc6b:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1192?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit d9b4723da6d2fdb438ffb0bf6bfb0c6dd184cc6b:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
datakit
pushed a commit
to linuxkit/linuxkit-logs
that referenced
this pull request
Oct 29, 2018
Updated
{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}
{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}
{linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed}
{linuxkit/linuxkit d9b4723da6d2fdb438ffb0bf6bfb0c6dd184cc6b:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1192?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}
{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes"
[|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv";
326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type";
334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a";
344279607 justincormack: "I am working on an updated version of this.";
344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin";
345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?";
345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou";
345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]}
{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake"
[|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on";
340192010 GordonTheTurtle: "<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following thes";
340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context).";
340224169 w9n: "added some context to the description. ";
340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes (";
340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k";
340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava";
340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build";
340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th";
340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther";
340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let";
340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files.";
340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q";
340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about ";
341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this ";
341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But";
352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk";
355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash";
355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta";
355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l";
355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p";
355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n";
355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par";
355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` ";
355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the ";
355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. ";
355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n";
355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou";
355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil";
355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code ";
355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit ";
355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do";
355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m";
355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t";
355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t";
355491607 deitch: "Or perhaps `lkt template`?";
355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --";
355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it";
355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam";
355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta";
355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi";
355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba";
355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command ";
355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua";
355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement ";
355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work";
355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co";
355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067";
355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and";
355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl";
355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi";
355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain ";
356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu";
356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h";
356256042 w9n: "done";
356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin";
356567368 ijc: "I don't think there are objections to templating in general, my specific objecti";
356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g.";
356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag";
356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in";
356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y";
356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r";
356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly.";
356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n ";
356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)";
356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c";
356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] ";
356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done ";
356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi";
357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac";
357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]}
{linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once"
[|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've ";
344683866 deitch: "Pushed out in arm64 and x86";
355305421 deitch: "This one is open 6 weeks later, can we just take it as is?";
355305711 justincormack: "I think there was a preference for using files...";
355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]}
{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}
{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a}
{linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee}
{linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283}
Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93}
{linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75}
{linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1}
{linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}
{linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8}
{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}
{linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33}
{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}
{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}
{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}
{linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879}
{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}
{linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694}
{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}
{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}
{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}
{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}
{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}
{linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e}
{linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93}
{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}
{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}
{linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9}
{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}
{linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b}
{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}
{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}
{linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb}
{linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b}
{linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b}
{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}
{linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Winkelewski [email protected]
Add omitempty to yml declaration to enable marshalling valid yml.
Needed by linuxkit/linuxkit#2648