feat: Export milvusclient.annRequest (issue: #41261)

[mcamou]

Issue: #41261.

milvusclient.NewHybridSearchOption receives a variadic annRequests parameter. However, since milvusclient.annRequest is private, there is no way to declare a slice, therefore there is no way to make it fully generic (as in, create a slice of milvusclient.annRequests and pass them to NewHybridSearchOption. This PR renames milvusclient.annRequest to milvusclient.AnnRequest to export it.

This is an API change since it's renaming a struct. However, since the struct was previously private no external code depends on it, unless it's doing nasty things with reflection (in which case it should not depend on the name).

Signed-off-by: Mario Camou [email protected]

[sre-ci-robot]

Welcome @mcamou! It looks like this is your first PR to milvus-io/milvus 🎉

[mergify]

@mcamou Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com./milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

[mergify]

@mcamou

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

1. Title Format: The PR title must begin with one of these prefixes:

• feat: for introducing a new feature.
• fix: for bug fixes.
• enhance: for improvements to existing functionality.
• test: for add tests to existing functionality.
• doc: for modifying documentation.
• auto: for the pull request from bot.

2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

[mergify]

@mcamou Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

[mergify]

@mcamou go-sdk check failed, comment rerun go-sdk can trigger the job again.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (1f1c836) to head (9671541).
Report is 11 commits behind head on master.

❌ Your project check has failed because the head coverage (72.62%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #41356       +/-   ##
===========================================
- Coverage   81.86%   72.62%    -9.25%     
===========================================
  Files        1166      312      -854     
  Lines      181131    29015   -152116     
===========================================
- Hits       148283    21072   -127211     
+ Misses      26708     7943    -18765     
+ Partials     6140        0     -6140     

Components	Coverage Δ
Client	∅ <ø> (∅)
Core	72.62% <ø> (∅)
Go	∅ <ø> (∅)

see 1478 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mergify]

@mcamou E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[congqixia]

/lgtm

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, mcamou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• client/OWNERS [congqixia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mcamou]

I don't know what could have happened to codecov, since this is a simple rename. Also, regarding the E2E test, I have no idea what might be failing. I've had to add Arch Linux support to scripts/install_deps.sh, but I still can't get it to build. make replies with the following:

ERROR: Invalid setting '14.2.1' is not a valid 'settings.compiler.version' value.
Possible values are ['4.1', '4.4', '4.5', '4.6', '4.7', '4.8', '4.9', '5', '5.1', '5.2', '5.3', '5.4', '5.5', '6', '6.1', '6.2', '6.3', '6.4', '6.5', '7', '7.1', '7.2', '7.3', '7.4', '7.5', '8', '8.1', '8.2', '8.3', '8.4', '8.5', '9', '9.1', '9.2', '9.3', '9.4', '9.5', '10', '10.1', '10.2', '10.3', '10.4', '10.5', '11', '11.1', '11.2', '11.3', '11.4', '12', '12.1', '12.2', '12.3', '13', '13.1', '13.2', '14', '14.1']

I've had to install the conan1 package since running sudo pip3 install conan gives an error stating that pip3 packages cannot be installed globally, so I can't even run the tests locally.

[congqixia]

/run-cpu-e2e

[mergify]

@mcamou E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.