Skip to content

Add support for Redis Sentinel #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025
Merged

Add support for Redis Sentinel #1448

merged 2 commits into from
Apr 6, 2025

Conversation

miguelgrinberg
Copy link
Owner

Discussion in #1444

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (288ebb1) to head (4e70145).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1448   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         2507      2530   +23     
  Branches       425       432    +7     
=========================================
+ Hits          2507      2530   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ithanil
Copy link

Ithanil commented Apr 2, 2025

LGTM and I have tested AsyncRedisManager+Sentinels with adapted OpenWebUI code successfully. Thank you very much for adding the support!

@miguelgrinberg miguelgrinberg merged commit 6a52e8b into main Apr 6, 2025
44 checks passed
@miguelgrinberg miguelgrinberg deleted the redis-sentinel branch April 6, 2025 15:15
@Ithanil
Copy link

Ithanil commented Apr 9, 2025

Do you plan on tagging a release with this feature soon or will it take some time?

@miguelgrinberg
Copy link
Owner Author

@Ithanil sorry for the delay. Version 5.13.0 is now out with this change.

@Ithanil
Copy link

Ithanil commented Apr 13, 2025

@miguelgrinberg Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants