Loading states for sync-in-progress #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-for-eshaan
changed the title
shivam-bit
suggested changes
May 23, 2024
|
|
||
| endpoint.handle.GET(nullSchema, async (req, res) => { | ||
| if (req.meta?.features?.use_mock_data) { | ||
| return res.send([1, 2, 3].map(() => uuid())); |
There was a problem hiding this comment.
[1,2,3] seems very odd, maybe directly use [uuid(),uuid(),uuid()] or declare it inside a mock file
shivam-bit
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues linked
#340
Start
Screen.Recording.2024-05-23.at.9.15.21.AM.online-video-cutter.com.1.mp4
End
Screen.Recording.2024-05-23.at.9.15.21.AM.online-video-cutter.com.mp4
bookmarked_reposfield to the Dora Metrics API response. The field contains an array of bookmarked repository IDs.getBookmarkedReposis implemented to fetch the bookmarked repos for a specific team.