Skip to content

Making API editorHoverVerbosityLevel use verbosityLevel instead of action #213317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented May 23, 2024

fixes #211153

This change has been done in order to allow the user to jump to a higher verbosity request instead of having to wait for the current one to finish.

The following shows the proposed change. There is a two second timeout when providing the hover content. Clicking twice the + icon ultimately retrieves the content for a hover request for verbosity level 2 instead of 1.

Screen.Recording.2024-05-23.at.16.42.32.mov

@aiday-mar aiday-mar self-assigned this May 23, 2024
@aiday-mar aiday-mar requested a review from jrieken May 23, 2024 14:46
@aiday-mar aiday-mar marked this pull request as ready for review May 23, 2024 14:46
@vscodenpa vscodenpa added this to the May 2024 milestone May 23, 2024
@aiday-mar aiday-mar merged commit 6cf8bdb into main May 23, 2024
6 checks passed
@aiday-mar aiday-mar deleted the breezy-mongoose branch May 23, 2024 20:01
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
…f `action` (microsoft#213317)

* allowing to cancel a previous request and jump directly to a request for a delta at a higher level

* adding code in order to dispose the token sources when the full object is disposed
@microsoft microsoft locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zooming doesn't cancel depending hover request
4 participants