Skip to content

Fix leaking uponSanitizeElement hook #213277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix leaking uponSanitizeElement hook #213277

merged 1 commit into from
May 23, 2024

Conversation

roblourens
Copy link
Member

@roblourens roblourens commented May 23, 2024

FYI @mjbvz @alexr00, if I scroll around in chat for a bit, we could end up running that hook 1000s of times. Doesn't actually cause a noticeable problem because it's very fast but caused an issue in a new unit test.

@roblourens roblourens enabled auto-merge (squash) May 23, 2024 01:51
@vscodenpa vscodenpa added this to the May 2024 milestone May 23, 2024
@roblourens roblourens merged commit cf2db6c into main May 23, 2024
7 checks passed
@roblourens roblourens deleted the roblou/vague-weasel branch May 23, 2024 02:07
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants