Skip to content

Tabs Multi Select Polish #212930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 21, 2024
Merged

Tabs Multi Select Polish #212930

merged 29 commits into from
May 21, 2024

Conversation

benibenj
Copy link
Contributor

This pull request includes polishes to multiselect for tabs

Related PR: #211712

@benibenj benibenj requested a review from bpasero May 16, 2024 21:05
@benibenj benibenj self-assigned this May 16, 2024
@benibenj benibenj enabled auto-merge (squash) May 16, 2024 21:05
@vscodenpa vscodenpa added this to the May 2024 milestone May 16, 2024
bpasero
bpasero requested changes May 17, 2024
View reviewed changes
@bpasero bpasero mentioned this pull request May 17, 2024
Merged
bpasero
bpasero requested changes May 20, 2024
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for multiEditorTabsControl

@benibenj benibenj requested a review from bpasero May 20, 2024 16:27
@benibenj
Copy link
Contributor Author

I've decided to remove selectEditors & unselectedEditors and switched to setting the entire selection each time. This does make it a bit nicer for the model and the view. The consumer of setting selection is required to do more work now, but I think it's fine.

I decided to use setSelection(activeSelectedEditor: EditorInput, inactiveSelectedEditors: EditorInput[]) instead of just passing a single array. I prefer the explicit knowledge of specifying which editor will be active and which inactive. It also enforces that an active editor is set.

@benibenj benibenj merged commit 54d31be into main May 21, 2024
6 checks passed
@benibenj benibenj deleted the benibenj/gothic-magpie branch May 21, 2024 14:00
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
@benibenj @bpasero @andremmsilva
Tabs Multi Select Polish (microsoft#212930)
8b0a86d 
* Tabs Multi Select Polish

* 💄

* add todo

* add todo

* update

* 💄

* 💄

* 💄

* more review

* 💄

* 💄

* fix bad function call

* remove todo

* jsdoc

* 💄

* fix typo

* 💄

* 💄

* 💄 multiEditorTabs

* model accepts multiple editors

* Use setSelection()

* fix tests

* 💄

* 💄

* discussion

* discussion

* fix selection

* typo

---------

Co-authored-by: Benjamin Pasero <[email protected]>
@microsoft microsoft locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@benibenj @bpasero @dbaeumer @vscodenpa