feat: Introduce a setting to control whether non-Java resources should be filtered #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
previously approved these changes
Apr 13, 2023
|
People from VS Code says that it is by design that the property of an object setting will not have the setting change update event: microsoft/vscode#179842 (comment) If we want to expose this setting to a command, we need to change it. I'm thinking to change it to: java.project.explorer.showNonJavaResources. Will append a commit to address that. |
jdneo
force-pushed
the
cs/switch-non-java-file
branch
from
3af4437 to
5438e1d
Compare
|
New UX: Give up using two commands toggling each other. Now using a static command to control all the filters in case that in the future new filters will be added. switch-non-java-setting.mp4 |
CsCherrYY
reviewed
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
switch-non-java-setting.mp4
The next step is add a button to quickly switch the behavior. It's not implemented yet due to an issue in VS Code: microsoft/vscode#179842