Skip to content

ux: Expose rebuild workspace command #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

ux: Expose rebuild workspace command #623

merged 2 commits into from
Jun 9, 2022

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jun 7, 2022

fix #619
image

1654568597

We will use the tools icon for now per discussion here

Signed-off-by: sheche [email protected]

@jdneo jdneo added this to the 0.20.0 milestone Jun 7, 2022
@jdneo jdneo added the UX label Jun 7, 2022
@jdneo jdneo requested a review from testforstephen June 7, 2022 05:22
@jdneo jdneo requested a review from CsCherrYY June 9, 2022 06:48
@CsCherrYY
Copy link
Contributor

can we consider putting the rebuild button ahead of the "export jar"?

@jdneo
Copy link
Member Author

jdneo commented Jun 9, 2022

Any reason for that?

@CsCherrYY
Copy link
Contributor

IMO build/rebuild commands should have a higher priority than publishing artifact (export jar is under this kind) ones.

@jdneo
Copy link
Member Author

jdneo commented Jun 9, 2022

IMO build/rebuild commands should have a higher priority than publishing artifact (export jar is under this kind) ones.

The priority of the icons in the navigation bar does not differ a lot. Since we only have 4 icons there (exclude the overflow button), put it as second or third position should not differ a lot.

From the UI perspective, put the build icon to the second one will look like this:
image
Personally, I don't like the visual effect because the icon of build is more complex than the ones next to it.

@CsCherrYY
Copy link
Contributor

IMO build/rebuild commands should have a higher priority than publishing artifact (export jar is under this kind) ones.

The priority of the icons in the navigation bar does not differ a lot. Since we only have 4 icons there (exclude the overflow button), put it as second or third position should not differ a lot.

From the UI perspective, put the build icon to the second one will look like this: image Personally, I don't like the visual effect because the icon of build is more complex than the ones next to it.

Get it and agree. Let's keep this version.

@jdneo jdneo merged commit 5de25ac into main Jun 9, 2022
@jdneo jdneo deleted the cs/issue-619 branch June 9, 2022 08:29
@jdneo jdneo mentioned this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the rebuild action to navigation bar
3 participants