Skip to content

Apply debounce to DependencyDataProvider's refreshing #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2019
Merged

Apply debounce to DependencyDataProvider's refreshing #183

merged 6 commits into from
Sep 27, 2019

Conversation

Vigilans
Copy link
Member

@Vigilans Vigilans commented Sep 27, 2019

Although #182 solves the NPE problem, the direct cause of the exception is the too frequent refresh request.

This PR applys debounce to refresh request, make sures that only one refresh request is sent every 2 seconds.

@msftclas
Copy link

msftclas commented Sep 27, 2019

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for contribution.

@testforstephen testforstephen merged commit d6fc145 into microsoft:master Sep 27, 2019
@Vigilans Vigilans deleted the vigilans/refresh-debounce branch September 30, 2019 06:57
@testforstephen testforstephen added this to the 0.6.0 milestone Oct 14, 2019
@testforstephen
Copy link
Contributor

We also support customizing the auto refresh delay time via the user setting java.dependency.refreshDelay. The default value is 2000 ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants