Fix the sync issue with non-java files #131
Conversation
| } | ||
|
|
||
| public static IJarEntryResource createJarResource(URI uri) throws JavaModelException { | ||
| String handleId = uri.getQuery(); |
There was a problem hiding this comment.
Null check or compatible check for URI getQuery here.
| return uri != null && JDT_SCHEME.equals(uri.getScheme()) && CONTENTS_AUTHORITY.equals(uri.getAuthority()); | ||
| } | ||
|
|
||
| public static IJarEntryResource createJarResource(URI uri) throws JavaModelException { |
There was a problem hiding this comment.
This function name is misleading. You didn't create any resource here. The function just enumerate all resource files and return the list.
| } | ||
| } | ||
| if (resource instanceof JarEntryDirectory) { | ||
| JarEntryDirectory directory = (JarEntryDirectory) resource; |
There was a problem hiding this comment.
If the first one failed, it will not continue the search in other folders. Is this by design?
| public static IPath removeProjectSegment(String projectElementName, IPath path) { | ||
| if (projectElementName.equals(path.segment(0))) { | ||
| return path.removeFirstSegments(1).makeRelative(); | ||
| } | ||
| return path; | ||
| } | ||
|
|
||
| public static PackageNode createNodeForProject(IJavaElement javaElement) { |
There was a problem hiding this comment.
Why all these functions are in the utility class? The file will be bloated with static methods. Please organize the logic clearly.
| return projectNode; | ||
| } | ||
|
|
||
| public static PackageNode createNodeForResource(IResource resource) { |
There was a problem hiding this comment.
Please keep the resource operation in well organized manner.
There was a problem hiding this comment.
See the item 1 of Effecitve Java 3rd for your reference: https://www.safaribooksonline.com/library/view/effective-java-3rd/9780134686097/ch2.xhtml#lev1
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Create the node list from buttom to top until project |
| * @return | ||
| * @throws JavaModelException | ||
| */ | ||
| private static List<PackageNode> getParentListToProject(IResource element) throws JavaModelException { |
There was a problem hiding this comment.
not parent list, but ancestor or path.
| * @return | ||
| * @throws JavaModelException | ||
| */ | ||
| private static List<PackageNode> getParentAncestorNodes(IResource element) throws JavaModelException { |
No description provided.