Add referenced libraries as reference container #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andxu
reviewed
Nov 19, 2018
| List<IClasspathEntry> referenceLibraries = Arrays.stream(references).filter(entry -> entry.getEntryKind() == IClasspathEntry.CPE_LIBRARY) | ||
| .collect(Collectors.toList()); | ||
| if (referenceLibraries.size() > 0) { | ||
| result.add(new ContainerNode("ReferencedLibraries", REFERENCED_LIBRARIES_PATH, NodeKind.CONTAINER, IClasspathEntry.CPE_CONTAINER)); |
There was a problem hiding this comment.
ContainerNode("ReferencedLibraries", REFERENCED_LIBRARIES_PATH, NodeKind.CONTAINER, IClasspathEntry.CPE_CONTAINER) should be a constant
andxu
reviewed
Nov 19, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Nov 20, 2018
| * Get container node of referenced libraries | ||
| */ | ||
| private static ContainerNode getReferencedLibrariesContainerNode() { | ||
| return new ContainerNode(REFERENCED_LIBRARIES_CONTAINER_NAME, REFERENCED_LIBRARIES_PATH, NodeKind.CONTAINER, IClasspathEntry.CPE_CONTAINER); |
There was a problem hiding this comment.
a static final field will do this well than a static method
andxu
previously approved these changes
Nov 20, 2018
andxu
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add referenced libraries as reference container