fix 'undefined is not iterable' when printing json output #40

beerose · 2023-10-20T17:41:54Z

currently running analyze-trace with --json flag results in:

Internal Error: undefined is not iterable (cannot read property Symbol(Symbol.iterator))\nTypeError: undefined is not iterable

(getHotSpotsWorker can return undefined in some cases)

jakebailey · 2023-10-20T17:45:46Z

src/print-trace-analysis-json.ts

@@ -111,7 +111,7 @@ async function getHotSpotsWorker(curr: EventSpan, currentFile: string | undefine
        // Sort slow to fast
        const sortedChildren = curr.children.sort((a, b) => (b.end - b.start) - (a.end - a.start));
        for (const child of sortedChildren) {
-            children.push(...await getHotSpotsWorker(child, currentFile, positionMap, relatedTypes, importExpressionThreshold));
+            children.push(...(await getHotSpotsWorker(child, currentFile, positionMap, relatedTypes, importExpressionThreshold) || []));


This shouldn't be possible; the return type is declared as Promise<HotFrame[]>

fix 'undefined is not iterable' when printing json output

2012fec

jakebailey reviewed Oct 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix 'undefined is not iterable' when printing json output #40

fix 'undefined is not iterable' when printing json output #40

beerose commented Oct 20, 2023

jakebailey Oct 20, 2023

fix 'undefined is not iterable' when printing json output #40

Are you sure you want to change the base?

fix 'undefined is not iterable' when printing json output #40

Conversation

beerose commented Oct 20, 2023

jakebailey Oct 20, 2023

Choose a reason for hiding this comment