Move Terminal from node-core-library to the terminal package.
#3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz,
patmill and
sachinjoseph
as code owners
D4N14L
approved these changes
Jan 20, 2022
rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureStorageBuildCacheProvider.ts
Outdated
Show resolved
Hide resolved
iclanton
force-pushed
the
move-terminal
branch
4 times, most recently
from
5b73b44 to
6d80a9f
Compare
dmichon-msft
approved these changes
Jan 25, 2022
iclanton
force-pushed
the
move-terminal
branch
2 times, most recently
from
ba1c9a1 to
5b2f93a
Compare
iclanton
force-pushed
the
move-terminal
branch
2 times, most recently
from
d3e2173 to
510f117
Compare
octogonz
reviewed
Oct 10, 2023
octogonz
reviewed
Oct 10, 2023
octogonz
reviewed
Oct 10, 2023
octogonz
reviewed
Oct 10, 2023
octogonz
reviewed
Oct 10, 2023
octogonz
reviewed
Oct 10, 2023
octogonz
reviewed
Oct 10, 2023
iclanton
force-pushed
the
move-terminal
branch
from
9765708 to
cac3003
Compare
iclanton
force-pushed
the
move-terminal
branch
from
a3a6cdf to
4e3e60c
Compare
iclanton
force-pushed
the
move-terminal
branch
2 times, most recently
from
f759bba to
8b9710e
Compare
iclanton
force-pushed
the
move-terminal
branch
from
8b9710e to
81f4887
Compare
octogonz
reviewed
Feb 17, 2024
octogonz
approved these changes
Feb 17, 2024
octogonz
reviewed
Feb 17, 2024
octogonz
reviewed
Feb 17, 2024
iclanton
force-pushed
the
move-terminal
branch
from
cfaad75 to
3707ab0
Compare
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change moves
Terminaland related APIs from@rushstack/node-core-libraryto@rushstack/terminaland changes the way colors are generated. Instead ofColors.colorNamereturning a structure describing how to generate the color, it will now simply return a string with the ASCII color codes.Details
This is a breaking change to the
TerminalAPI. Support is included for the oldIColorableSequenceobjects, but this is not included in the types.Part of #3147
Specific API changes:
Terminal,ITerminal,ITerminalProvider, and the terminal provider implementations were removed from@rushstack/node-core-libraryand moved to@rushstack/terminalwith API changesColorsandIColorableSequencewere removed from@rushstack/node-core-library; instead use the newColorizeAPI from@rushstack/terminalITerminalWritableOptionsfrom@rushstack/terminalwas renamed toITerminalStreamWritableOptionsTerminalWritablewas removed from@rushstack/node-core-library; instead use the newTerminalStreamWritableAPI from@rushstack/terminalHow it was tested
Tests were moved and expanded, projects in the repo were updated to use the new APIs.