Skip to content

Draft: Implement Modal having a titlebar and moveable #14598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iamAbhi-916
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 commented Apr 21, 2025

Description

Implement Modal having a titlebar and moveable

Type of Change

Erase all that don't apply.

  • New feature (non-breaking change which adds functionality)

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.

Resolves [Add Relevant Issue Here]
#14067

What

What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.

Screenshots

Add any relevant screen captures here from before or after your changes.

Testing

If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.

Optional: Describe the tests that you ran locally to verify your changes.

Changelog

Should this change be included in the release notes: indicate yes or no

Add a brief summary of the change to use in the release notes for the next release.

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 requested a review from a team as a code owner April 21, 2025 20:10
@iamAbhi-916 iamAbhi-916 marked this pull request as draft April 21, 2025 20:45
@TatianaKapos
Copy link
Contributor

Two things here

  1. Make sure to test with USE_EXPERIMENTAL_WINUI3="true" aswell, in the future we will want to transition to the experimental_winui3 which uses different APIs
  2. More work is needed to get Modal working with the titlebar's close button, try closing and reopening the modal to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants