-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement OnScrollEndDrag Event Handler for ScrollView #14473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@sharath2727 Can you fill out |
vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp
Outdated
Show resolved
Hide resolved
@sharath2727 RNW setup is a little different than other repos, we want to keep our branches clean to not clutter up the stable branches. PRs should come from your own forked repository of the react-native-windows repo, see https://github.com./microsoft/react-native-windows/blob/main/docs/contributing.md for more information! I think @Yajur-Grover also recorded some videos on how to do so! This PR is fine but just going forward! :) |
Description
Type of Change
Enhancement (non-breaking change)
Why
Implement OnScrollEndDrag Event Handler for fabric implementation of ScrollView.
Resolves #13143
What
For reference: https://learn.microsoft.com/en-us/uwp/api/windows.ui.composition.interactions.interactiontracker?view=winrt-26100
Testing
Updated the ScrollViewSnapSample.tsx to include onScrollEndDrag event handler and verified the console prints onScrollEndDrag when interaction with scroller stops and lnertia state enters.
Optional: Used playground-composition.sln and metro server to test my changes.
Changelog
yes
Support OnScrollBeginDrag and OnScrollEndDrag event Handling for ScrollView
Microsoft Reviewers: Open in CodeFlow