-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add linter exception to generated headers for Office builds #14157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
@sagokhal You need to run |
This reverts commit c6bf952.
acoates-ms
approved these changes
Dec 5, 2024
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Dec 9, 2024
…t#14157) * Add linter exception to generated headers for Office builds
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Dec 9, 2024
…t#14157) * Add linter exception to generated headers for Office builds
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Dec 9, 2024
…t#14157) * Add linter exception to generated headers for Office builds
acoates-ms
added a commit
that referenced
this pull request
Dec 10, 2024
…hildrenInto (#14187) * Add linter exception to generated headers for Office builds (#14157) * Add linter exception to generated headers for Office builds * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto (#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix * fix --------- Co-authored-by: Sarang Gokhale <[email protected]>
acoates-ms
added a commit
that referenced
this pull request
Dec 10, 2024
…hildrenInto (#14188) * Add linter exception to generated headers for Office builds (#14157) * Add linter exception to generated headers for Office builds * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto (#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix * change files * fix --------- Co-authored-by: Sarang Gokhale <[email protected]>
acoates-ms
added a commit
that referenced
this pull request
Dec 10, 2024
…hildrenInto (#14186) * Add linter exception to generated headers for Office builds (#14157) * Add linter exception to generated headers for Office builds * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto (#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix * fix --------- Co-authored-by: Sarang Gokhale <[email protected]>
sagokhal
added a commit
to sagokhal/react-native-windows
that referenced
this pull request
Dec 11, 2024
… for Office builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add linter exception to generated headers for Office builds by adding
// clang-format off
Testing
No functional code changes. This only adds a comment to the generated headers.
Microsoft Reviewers: Open in CodeFlow