contextPath relative to CWD and resolvers return readonly array #231
Conversation
|
I think we should consider having @freiksenet @vejrj what do you think? |
|
Yeah, this looks good. Let's do that. |
| if (!contextImport) { | ||
| return; | ||
| } | ||
| const contextDir = path.join(path.dirname(inputPath), contextImport); | ||
| const contextDir = path.join(process.cwd(), contextImport); |
There was a problem hiding this comment.
Just FYI for future changes, this is equivalent to path.resolve(contextImport)
| factory.createTypeReferenceNode( | ||
| factory.createIdentifier("ReadonlyArray"), | ||
| [type as ts.TypeNode], | ||
| ), |
There was a problem hiding this comment.
iirc, the way to do this with modern TS and through the API is something like:
factory.createTypeOperatorNode(ts.SyntaxKind.ReadonlyKeyword, factory.createArrayTypeNode(type))Which would produce:
readonly X[]
This reverts commit 0a2968d.
| export type ImmutableSet<T> = ReadonlySet<Immutable<T>>; | ||
| export type ImmutableObject<T> = { readonly [K in keyof T]: Immutable<T[K]> }; | ||
|
|
||
| export type PromiseOrValue<T> = Immutable<T> | Promise<Immutable<T>>; |
There was a problem hiding this comment.
I have to wonder how expensive this might be vs the previous inlined solution, when compiling or trying to get instant feedback from the LSP.
There was a problem hiding this comment.
Yeah, there are other problems with it as well (posted in a separate comment). Let's stick with a simple approach then (at least for now)
|
Generic immutable seems to be a hard thing to do right (see full discussion in this thread). So, for now we'll have to stick with explicit |
No description provided.