chore(deps): Move typescript to peerDependencies

[ExE-Boss]

Fixes #281

Depends on:

• chore: Add typescript@next to devDependencies DefinitelyTyped/DefinitelyTyped#45148

[sandersn]

I think it's actually the fault of dtslint's dependencies dts-critic and @definitelytyped/definitions-parser. dtslint needs to depend directly on typescript so that it can be run via package.json's bin entry.

[ExE-Boss]

That will also work with peer dependencies.

[sandersn]

#296 updated dtslint's dependencies. I published it and will watch DT to see if it works.

[sandersn]

(It works locally.)

[Maxim-Mazurok]

I think it's actually the fault of dtslint's dependencies dts-critic and @definitelytyped/definitions-parser. dtslint needs to depend directly on typescript so that it can be run via package.json's bin entry.

That doesn't seem to be the case. Even with latest dtslint, I still can reproduce the issue.
Here's what happens:

• I have [email protected] as a dependency of my project.
• I'm running dtslint
• dtslint imports and calls tslint
• tslint doesn't have typescript dependency, so it uses my projects version to parse ts files and convert them into linkable structure
• dtslint rule voidReturnRule also imports typescript but since dtslint has typescript dependency, it uses local ts version which has different enum values

Here's an illustration:

[Maxim-Mazurok]

I just tried this fork (PR) on my project using npm link and it worked perfectly!
I was running it using bin like so:

./node_modules/.bin/dtslint types/gapi.client.abusiveexperiencereport

[Maxim-Mazurok]

LGTM 👍

[IvanGoncharov]

This is exactly the fix we need to make dtslint reliably working in graphql-js 👍

[sandersn]

I'll merge this and ship it as soon as DefinitelyTyped/DefinitelyTyped#45226 is in.

[sandersn]

OK, 3.6.10 is published, let me know if there are problems.

[IvanGoncharov]

@sandersn It fixed every for graphql-js.
The next challenge is to understand why our typing is failing strict-export-declare-modifiers but I think it is a different bug.