Skip to content

Revert "Fix app service start (regression)" #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kebson01
Copy link

Reverts #428

@davidxw
Copy link
Member

davidxw commented Feb 12, 2025

@kebson01 I think I rolled back this change because when the site doesn't render properly when not started with "next start" and when deployed via azd (which sets SCM_DO_BUILD_DURING_DEPLOYMENT to true). In our sample pipeline deployments we build locally, set SCM_DO_BUILD_DURING_DEPLOYMENT to false, push a static site, and run as a node application. We've assumed that the majority of users of this repo will be using azd so we've made that the default start command in the templates compatible with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants