Fix FileSurfer to locate and list files #6275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#6234 Update `test_filesurfer_agent.py` to handle valid directory paths. * Add `test_open_path_valid_directory` test to verify that `FileSurfer` can read a valid directory without returning `FileNotFoundError`. * Mock API calls and create a test directory for the new test case. * Validate that the `FileSurfer` agent correctly reads the directory and returns the expected content.
ekzhu
reviewed
Apr 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6275 +/- ##
=======================================
Coverage 77.27% 77.27%
=======================================
Files 200 200
Lines 14322 14322
=======================================
Hits 11068 11068
Misses 3254 3254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6234
Update
test_filesurfer_agent.pyto handle valid directory paths.test_open_path_valid_directorytest to verify thatFileSurfercan read a valid directory without returningFileNotFoundError.FileSurferagent correctly reads the directory and returns the expected content.