Skip to content

Fix component.label error in AGS frontend #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 6, 2025
Merged

Conversation

victordibia
Copy link
Collaborator

@victordibia victordibia commented Mar 6, 2025

Fix issue here in this discussion - #4208 (comment)

Why are these changes needed?

Fix bug in AGS UI where frontend crashes because the default team config is null

  • update /teams endpoint to always return a default team if none is found for the user
  • update UI to check for team before rendering
  • also update run_id type to be autoincrement int (similar to team id) instead of uuid. This helps side step the migration failed errors related to UUID type when using an sqlite backend

Related issue number

Checks

@victordibia victordibia requested a review from ekzhu March 6, 2025 05:12
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.60%. Comparing base (7e5c115) to head (3e31b6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5845   +/-   ##
=======================================
  Coverage   75.60%   75.60%           
=======================================
  Files         189      189           
  Lines       12734    12734           
=======================================
  Hits         9627     9627           
  Misses       3107     3107           
Flag Coverage Δ
unittests 75.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can convert back to using UUID in the future as auto increment ids tend to slow down at scale

@victordibia victordibia merged commit 648f734 into main Mar 6, 2025
55 checks passed
@victordibia victordibia deleted the fix_label_not_found_ags branch March 6, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants