Only skip following inference steps after union member matching if an inference is actually made

[weswigham]

Fixes #33131

I'm not sure if you'd like to reconsider more here, but, generally speaking, this seems like a fairly minimal tweak to the logic we added to better match union/intersection types that un-breaks rxjs with only a minimal (and arguably beneficial) change to our own baselines.

[weswigham]

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at 737d1e7. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 737d1e7. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 737d1e7. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[weswigham]

I think this fixes an issue in the azure sdk. Or they fixed one since my last result and for the fourth time today, again the user baselines are just today's as yet uncaptured/accepted update (just changes in upstream projects), and thus are clean~

[weswigham]

Also removes an error in RWC of the form Argument of type '{ [name: string]: unknown; }' is not assignable to parameter of type '{ [name: string]: string | number; }', which seems like a fix to me.

[weswigham]

The two DT changes are related, and I need to look at the lodash one in detail, but I think the new handful of results are probably just as good if not better than the old ones.

@typescript-bot pack this for posterity. And testing.

@benlesh does this fixup inference in all of rxjs?

[typescript-bot]

Heya @weswigham, I've started to run the tarball bundle task on this PR at 737d1e7. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/42167/artifacts?artifactName=tgz&fileId=84FA9BD7390E9AE04ED6006D9E265FBCF309C643377CBBC8CB1CE445229AAB2B02&fileName=/typescript-3.7.0-insiders.20190830.tgz"
    }
}

and then running npm install.

[weswigham]

@ahejlsberg has an alternative implementation he'll have a PR up for shortly