Fix build failure with newest @types/mocha
#21075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
mhegazy
reviewed
Jan 8, 2018
| @@ -55,7 +55,7 @@ namespace Harness.Parallel.Worker { | |||
| retries() { return this; }, | |||
| slow() { return this; }, | |||
| timeout(n) { | |||
| timeout = n; | |||
| timeout = n as number; | |||
There was a problem hiding this comment.
Depends on whether we believe it to be a number already, or believe that it actually could be a string and want to convert it to a number at runtime. @weswigham might know if the new type definition is actually accurate to our situation
|
Technically if it's a string we should parse it using similar logic to mocha, but we don't use the string version at any callsite (ofc, it typechecked before), so a cast is likely fine for now. Doing more would be pointless, since we don't use it. |
ghost
mentioned this pull request
|
@mhegazy @weswigham Good to go? |
mhegazy
approved these changes
Jan 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like in the newest version of
@types/mocha, this callback can give us a string.