Salsa: "Implicit globals" leak into member completions but not global completions?

[egamma]

From @alexandrudima on January 27, 2016 13:34

Testing #2218

IMHO member completions should get less suggestions than the global completions, not the other way around:

function f() {
    // helloWorld leaks from here into the global space?
    if (helloWorld) {
        return 3;
    }
    return 5;
}

// helloWorld is proposed here
// Number(3).

// helloWorld is not proposed here
// hello

Copied from original issue: microsoft/vscode#2447

[RyanCavanaugh]

@billti how should we fix this?

• Add all tokens in the current file to the global completion list. -- or --
• Remove token-based items from the member list (when it is non-empty)

[mhegazy]

the later is an problem when we guess things wrong:

var x = {};
x.a = 0;
x.b = "string";
x.|

The earlier seems like a more consistent approach. VSCode should show these completions as a different icon. the CompletionEntry.kind field should be the marker here, also CompletionEntry.sortKey should push these all to the bottom.

[egamma]

VSCode should show these completions as a different icon.

@mhegazy we have already changed the icon in our latest:

.

[pflannery]

@RyanCavanaugh Did this fix scope variables leaking in to instance completions?

I just got the latest vscode 0.10.10 and now see this type of polluted intellisense all over my js apps:

I would only expect to see similar to this

Source:

class SomeClass {
  constructor(param1, param2, param3) {
    this.param1 = param1;
    this.param2 = param2;
    this.param3 = param3;
  }

  doSomething() {

  }
}
var a, b, c, d, e;
var instance = new SomeClass(1, 2, 3);

[billti]

This is by design. We show the properties we know to exist with a definitive icon at the top, and the rest of the identifiers in the file afterwards. In the more recent builds the assignment to this. in the constructor would be recognized also (e.g. as shown below on my machine).

[pflannery]

@billti thanks for the info. Is there a way to turn of this noise?

[mnpenner]

@billti Is there any way to hide the extraneous identifiers? I don't see how x.Foo or x.get would ever make sense. It just looks like clutter to me.