-
Notifications
You must be signed in to change notification settings - Fork 12.8k
project references out of memory crash #30429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've been debugging this a little. This is going to be a brain dump of findings so far.
At this point, it's already gone off down the wrong path imo. Some earlier check should have been able to say "Aha, I have two |
My guess is that any library that exports a reasonably complex set of types will be at risk of this crash. It just so happens that fp-ts is particularly complex so it hits the limit straight away. |
@DanielRosenwasser Do you have any pointers on how I would go about writing a test case to cover this scenario? Or is there a similar test case for some other feature that I could use as a guide? I'm struggling a bit to find a decent start point. 🤔 |
Your repro seems small enough that we should be able to work with it. I think @RyanCavanaugh and I are just a little overdue for triaging. |
Great, thanks! I know you're pretty busy with 3.4 and 3.5 so if this isn't likely to make it in those cycles then I'd like to hack on it myself (it's a blocker for us using project refs). If someone could give me a leg up on the right way to cover a failure mode like this with a test, I can maybe gather some more useful intel. |
Futher braindumping:
|
Full stack trace:
|
@RyanCavanaugh I'm trying to build a short-circuit into For example, I've got I want to eventually write |
The issue here is that there is mismatch in package id for the duplicate id file: |
I'm still encountering the problem when using |
TypeScript Version: 3.4.0-dev.20190315
Search Terms: project references composite oom
Code
https://github.com./leemhenson/project-refs-oom-repro
Expected behavior:
After doing the yarn install dance,
cd stacks/project-one && tsc -b --verbose
should complete without any issues.Actual behavior:
cd stacks/project-one && tsc -b --verbose
hangs and gradually chomps up enough memory to stack overflow. The cause is theOption<Date>
annotation here:https://github.com./leemhenson/project-refs-oom-repro/blob/master/stacks/project-one/src/app.ts#L5
Related Issues:
#25023
#29597
The text was updated successfully, but these errors were encountered: