Skip to content

Fix typo that prevent tag(s) to be assigned to new issue #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Fix typo that prevent tag(s) to be assigned to new issue #76

merged 1 commit into from
Dec 14, 2018

Conversation

lazywinadmin
Copy link
Contributor

@lazywinadmin lazywinadmin commented Dec 14, 2018

When using:

New-GitHubIssue -OwnerName lazywinadmin -RepositoryName lazywinadmin.github.io -Title PowerShellTest6 -Body test -Label 'blog comments','bug'

The labels are not assigned to the new issue.

This PR fix the problem, just a typo.

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow...thanks for the fix, François-Xavier! Looks like we need to see why this didn't get caught with the unit tests.

@HowardWolosky HowardWolosky merged commit 3b6e84c into microsoft:master Dec 14, 2018
HowardWolosky added a commit to HowardWolosky/PowerShellForGitHub that referenced this pull request Dec 14, 2018
Issue microsoft#76 recent fixed a bug where Labels
were not being correctly added to Issues at the
time of creation.

This new UT will ensure that is always tested going
forward.

Additionally, this updates all UT's to disable telemetry
and enable logging of the request body to ease debugging.
HowardWolosky added a commit that referenced this pull request Dec 14, 2018
Issue #76 recent fixed a bug where Labels
were not being correctly added to Issues at the
time of creation.

This new UT will ensure that is always tested going
forward.

Additionally, this updates all UT's to disable telemetry
and enable logging of the request body to ease debugging.
HowardWolosky added a commit to HowardWolosky/PowerShellForGitHub that referenced this pull request Dec 14, 2018
Similar to microsoft#76, `Update-GitHubIssue` was passing in the provided
labels as `label` instead of `labels` in the request body.
HowardWolosky added a commit that referenced this pull request Dec 14, 2018
Similar to #76, `Update-GitHubIssue` was passing in the provided
labels as `label` instead of `labels` in the request body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants