Add support for comment APIs #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseartrivera
commented
Nov 26, 2018
danbelcher-MSFT
previously approved these changes
Nov 26, 2018
danbelcher-MSFT
previously approved these changes
Nov 27, 2018
HowardWolosky
requested changes
Nov 27, 2018
There was a problem hiding this comment.
Thanks for the submission. This is a great start, but I think that there is some opportunity for improvement.
You may also want to look at the Repository Comments docs that talks about commit comments. WIth a moderate amount of additional work you may be able to support all comment types with this PR. You can of course choose to defer and have these methods updated at some future point in time to support those additional values.
HowardWolosky
requested changes
Nov 28, 2018
|
@HowardWolosky I will tackle repository comments (https://developer.github.com./v3/repos/comments/) in a seperate PR |
HowardWolosky
requested changes
Nov 30, 2018
HowardWolosky
requested changes
Nov 30, 2018
HowardWolosky
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for all of the Github Comment APIs.