Skip to content

Fix static analysis misses with new Fork featurework #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,33 @@
# PowerShellForGitHub PowerShell Module
## Changelog

## [0.0.2](https://github.com./PowerShell/PowerShellForGitHub/tree/0.3.0) - (2018/11/13)
## [0.3.1](https://github.com./PowerShell/PowerShellForGitHub/tree/0.3.1) - (2018/11/13)
### Fixes:
* Minor static analysis issues fixed.
* Corrected name of the test file for `GitHubRepositoryForks`
* Ensured the `getParams` are used during execution of `Get-GitHubRepositoryFork`

More Info: [[pr]](https://github.com./PowerShell/PowerShellForGitHub/pull/42) | [[cl]](https://github.com./PowerShell/PowerHellForGitHub/commit/TODO)

Author: [**@HowardWolosky**](https://github.com./HowardWolosky)

------

## [0.3.0](https://github.com./PowerShell/PowerShellForGitHub/tree/0.3.0) - (2018/11/13)
### Features:
+ Added support for querying forks and creating new ones.

### Fixes:
* Will only perform a retry when receiving a `202` response on a `GET` request. Previously, it would
retry regardless of the method of the request.

More Info: [[pr]](https://github.com./PowerShell/PowerShellForGitHub/pull/41) | [[cl]](https://github.com./PowerShell/PowerHellForGitHub/commit/TODO)
More Info: [[pr]](https://github.com./PowerShell/PowerShellForGitHub/pull/41) | [[cl]](https://github.com./PowerShell/PowerHellForGitHub/commit/1076239d7639497984a6e0b04df1e69019c4ec28)

Author: [**@HowardWolosky**](https://github.com./HowardWolosky)

------

## [0.0.2](https://github.com./PowerShell/PowerShellForGitHub/tree/0.2.0) - (2018/11/13)
## [0.2.0](https://github.com./PowerShell/PowerShellForGitHub/tree/0.2.0) - (2018/11/13)
### Features:
+ Significant restructing and refactoring of entire module to make future expansion easier.
+ Significant documentation updates ([CHANGELOG](./CHANGELOG.md), [CONTRIBUTING.md](./CONTRIBUTING.md),
Expand Down
2 changes: 1 addition & 1 deletion GitHubRepositoryForks.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ function Get-GitHubRepositoryFork
)

$params = @{
'UriFragment' = "repos/$OwnerName/$RepositoryName/forks"
'UriFragment' = "repos/$OwnerName/$RepositoryName/forks`?" + ($getParams -join '&')
'Description' = "Getting all forks of $RepositoryName"
'AccessToken' = $AccessToken
'TelemetryEventName' = $MyInvocation.MyCommand.Name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Describe 'Creating a new fork for user' {
$newForks[0].full_name | Should be "$($script:ownerName)/PowerShellForGitHub"
}

Remove-GitHubRepository -OwnerName $script:ownerName -RepositoryName PowerShellForGitHub
Remove-GitHubRepository -Uri $repo.svn_url
}
}

Expand All @@ -107,7 +107,7 @@ Describe 'Creating a new fork for an org' {
$newForks[0].full_name | Should be "$($script:organizationName)/PowerShellForGitHub"
}

Remove-GitHubRepository -OwnerName $script:organizationName -RepositoryName PowerShellForGitHub
Remove-GitHubRepository -Uri $repo.svn_url
}
}

Expand Down