Skip to content

Reimagining status for the module #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2020
+138 −482
Merged

Reimagining status for the module #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0a95d2
Reimagining status for the module
HowardWolosky Jun 28, 2020
4576cae
CBH update
HowardWolosky Jun 29, 2020
7881d7d
Add back -WhatIf support to core methods until #254 is in.
HowardWolosky Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions GitHubConfiguration.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ function Set-GitHubConfiguration

.PARAMETER DefaultNoStatus
Control if the -NoStatus switch should be passed-in by default to all methods.
The -NoStatus switch has been deprecated. Commands in this module no longer display status
on the console, thus passing in -NoStatus to a command no longer has any impact.
Therefore, the value of this configuration setting also no longer has any impact on
command execution.

.PARAMETER DefaultOwnerName
The owner name that should be used with a command that takes OwnerName as a parameter
Expand Down Expand Up @@ -132,6 +136,14 @@ function Set-GitHubConfiguration
.PARAMETER LogTimeAsUtc
If specified, all times logged will be logged as UTC instead of the local timezone.

.PARAMETER MultiRequestProgressThreshold
Some commands may require sending multiple requests to GitHub. In some situations,
getting the entirety of the request might take 70+ requests occurring over 20+ seconds.
A progress bar will be shown (displaying which sub-request is being executed) if the number
of requests required to complete this command is greater than or equal to this configuration
value.
Set to 0 to disable this feature.

.PARAMETER RetryDelaySeconds
The number of seconds to wait before retrying a command again after receiving a 202 response.

Expand Down Expand Up @@ -212,6 +224,8 @@ function Set-GitHubConfiguration

[switch] $LogTimeAsUtc,

[int] $MultiRequestProgressThreshold,

[int] $RetryDelaySeconds,

[switch] $SuppressNoTokenWarning,
Expand Down Expand Up @@ -296,6 +310,7 @@ function Get-GitHubConfiguration
'LogProcessId',
'LogRequestBody',
'LogTimeAsUtc',
'MultiRequestProgressThreshold',
'RetryDelaySeconds',
'SuppressNoTokenWarning',
'SuppressTelemetryReminder',
Expand Down Expand Up @@ -640,6 +655,7 @@ function Import-GitHubConfiguration
'logProcessId' = $false
'logRequestBody' = $false
'logTimeAsUtc' = $false
'multiRequestProgressThreshold' = 10
'retryDelaySeconds' = 30
'suppressNoTokenWarning' = $false
'suppressTelemetryReminder' = $false
Expand Down
Loading