Skip to content

Adding advanced example #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 29, 2019
Merged

Conversation

lazywinadmin
Copy link
Contributor

Fix #102
I used this module to migrate my blog comments to Github Issues

See microsoft#102 
I used this module to migrate my blog comments to Github Issues
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for stepping up to add the link to the docs!

I think there are two types of people that read docs...those that read the ToC, and those that just skim until they find something important in the body of the doc.

So to get the most visibility to your blog post, I think this ToC entry should link to an similarly-named section at the bottom of the doc, and then just have a one-to-two sentence executive summary about the blog post accompanying the link.

Thanks again!

@lazywinadmin
Copy link
Contributor Author

lazywinadmin commented Jun 29, 2019

make sense, I'll update it
Thanks @HowardWolosky

-Added "Advanced" section at the bottom
-Added "blog comment migration" example
@lazywinadmin
Copy link
Contributor Author

lazywinadmin commented Jun 29, 2019

Done. I also added the piece of code related to PowerShellForGithub module
Let me know if it is ok with you, else I'll remove it.

@HowardWolosky

@lazywinadmin
Copy link
Contributor Author

@HowardWolosky Would you recommend any additional changes ?

@HowardWolosky
Copy link
Member

Apologies for the delay, I was traveling for ~2 weeks and have been trying to slowly get through a backlog of PR's across multiple projects. Will review this tomorrow.

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback here.

Thanks again for the update. I think it's fine to have a short snipped of code as you've done here, referring to the blog post for the full code.

@lazywinadmin
Copy link
Contributor Author

I addressed your comments/recommendations in my last edit.

@lazywinadmin
Copy link
Contributor Author

Hey @HowardWolosky , let me know if you need me to edit anything and I'll update my pr

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that update/simplification. Just a couple minor updates and we should be good to go.

lazywinadmin and others added 3 commits July 26, 2019 08:56
Co-Authored-By: Howard Wolosky <[email protected]>
Co-Authored-By: Howard Wolosky <[email protected]>
@lazywinadmin
Copy link
Contributor Author

@HowardWolosky Thanks for the suggestions. I updated the code. Let me know

Co-Authored-By: Howard Wolosky <[email protected]>
@lazywinadmin
Copy link
Contributor Author

@HowardWolosky Thanks, commited. Let me know

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry... Found one more.

Co-Authored-By: Howard Wolosky <[email protected]>
@lazywinadmin
Copy link
Contributor Author

@HowardWolosky done

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! Thanks for persevering through this and for doing it in the first place!

@HowardWolosky HowardWolosky merged commit 8da84fd into microsoft:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add use case: Migrate my blog comments from Disqus to Github Issues
2 participants