-
Notifications
You must be signed in to change notification settings - Fork 191
Adding advanced example #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See microsoft#102 I used this module to migrate my blog comments to Github Issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for stepping up to add the link to the docs!
I think there are two types of people that read docs...those that read the ToC, and those that just skim until they find something important in the body of the doc.
So to get the most visibility to your blog post, I think this ToC entry should link to an similarly-named section at the bottom of the doc, and then just have a one-to-two sentence executive summary about the blog post accompanying the link.
Thanks again!
make sense, I'll update it |
-Added "Advanced" section at the bottom -Added "blog comment migration" example
Done. I also added the piece of code related to PowerShellForGithub module |
@HowardWolosky Would you recommend any additional changes ? |
Apologies for the delay, I was traveling for ~2 weeks and have been trying to slowly get through a backlog of PR's across multiple projects. Will review this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback here.
Thanks again for the update. I think it's fine to have a short snipped of code as you've done here, referring to the blog post for the full code.
I addressed your comments/recommendations in my last edit. |
Hey @HowardWolosky , let me know if you need me to edit anything and I'll update my pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that update/simplification. Just a couple minor updates and we should be good to go.
Co-Authored-By: Howard Wolosky <[email protected]>
Co-Authored-By: Howard Wolosky <[email protected]>
@HowardWolosky Thanks for the suggestions. I updated the code. Let me know |
Co-Authored-By: Howard Wolosky <[email protected]>
@HowardWolosky Thanks, commited. Let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry... Found one more.
Co-Authored-By: Howard Wolosky <[email protected]>
@HowardWolosky done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huzzah! Thanks for persevering through this and for doing it in the first place!
Fix #102
I used this module to migrate my blog comments to Github Issues