Skip to content

Fix hReview backcompat #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aaronpk opened this issue Jan 25, 2017 · 1 comment
Closed

Fix hReview backcompat #107

aaronpk opened this issue Jan 25, 2017 · 1 comment

Comments

@aaronpk
Copy link
Member

aaronpk commented Jan 25, 2017

Currently the hReview backcompat parsing is pretty broken. Here's a live example:

http://pin13.net/mf2/?url=https%3A%2F%2Fw7apk.com%2Fkenwood-th-d74a
aaronpk added a commit to aaronpk/XRay that referenced this issue Jan 25, 2017
@aaronpk
support h-review and h-product vocab
5d8fb4e 
* closes #23
* major refactor of the methods for extracting properties to consolidate the logic
* hReview parsing is incomplete due to issues with the php-mf2 backcompat parsing. see microformats/php-mf2#107
@gRegorLove gRegorLove mentioned this issue Mar 18, 2017
Merged
@aaronpk
Copy link
Member Author

aaronpk commented Apr 27, 2017

This should be fixed in #111!

@aaronpk aaronpk closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronpk