Skip to content

fix: make filter work on count for consistency #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

The count endpoint generated with rest-crud has a where filter but doesn't have filter itself.
So GET /count?where={"name":<name>} would work but GET /count?filter={"where":{"name":<name>}} will not work.

I think this is intentional as the count endpoint would only require a where clause. But this causes inconsistency of filter in GET /count and GET / and PATCH /.

I am creating this draft PR to discuss if we add filter to /count too in order to make it consistent with other endpoints.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@aaqilniz
Copy link
Contributor Author

Hi, @dhmlau. Can you please have a look at this PR?

@dhmlau
Copy link
Member

dhmlau commented Mar 31, 2025

@aaqilniz, I haven't reviewed the changes yet. but could you please look into the CI failure first? Thanks.

@aaqilniz
Copy link
Contributor Author

aaqilniz commented Apr 8, 2025

Hi, @dhmlau. The tests are failing while publishing coverage reports are being published to Coversall. Everything else before is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants