Make ScyllaDB replication factor configurable #3788
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
04-14-make_scylladb_replication_factor_configurable
branch
from
6fd307a to
5e7a71d
Compare
| @@ -1339,7 +1343,7 @@ impl ClientOptions { | |||
| let storage_config = self.storage_config()?; | |||
| debug!("Running command using storage configuration: {storage_config}"); | |||
| let store_config = storage_config | |||
| .add_common_config(self.common_config()) | |||
| .add_common_config(self.common_config(), self.storage_replication_factor) | |||
There was a problem hiding this comment.
Isn't it what the common config was about though?
There was a problem hiding this comment.
First comment is that the addition of a storage-replication-factor is generally a good idea. I think that in operations, the ScyllaDb instance is not spun out in that way. But, it is a nice thing to have it available for tests.
Where I think this is more problematic is where should we put this setting.
As is apparent, this is not an internal setting of ScyllaDB. The ScyllaDB instance is already running, either in Docker or some other system. Therefore, the replication factor should be next to the uri and should be obtained when parsing the --storage entry.
Motivation
We'll use replication factor of 1 in CI and locally, but probably will use 3 in deployed networks on GCP
Proposal
Add an option to support that
Test Plan
CI + deployed network locally
Release Plan