PaymentBandwidth uses HtlcView
#1462
Conversation
Pull Request Test Coverage Report for Build 14597823788Details
💛 - Coveralls |
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
3 times, most recently
from
b3e79c5 to
1f94c7a
Compare
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
from
1f94c7a to
9bd9d79
Compare
| // The asset balance of the channel is simply not enough to | ||
| // route the asset units, we report 0 bandwidth in order for the | ||
| // HTLC to fail back. | ||
| return 0, nil | ||
|
|
||
| default: |
There was a problem hiding this comment.
This should not be possible, so it's just confusing to have the default case.
In fact, now that we definitely return from this function, we can turn the first case into an if. Then have the second case non-indented as the implicit else.
There was a problem hiding this comment.
the default was only added here for golang to not complain about the default return missing, could also add a default return outside the switch
Sure can switch to if , although I find switch much more readable as you see both cases explicitly being captured
There was a problem hiding this comment.
Can add a comment like "we shouldn't reach this" ?
There was a problem hiding this comment.
It's should return an error if it ever reaches a point it shouldn't.
There was a problem hiding this comment.
if it ever reaches a point it shouldn't.
It's not a "shouldn't" it's a "can't". We're not trusting that certain properties are respected in the code, the above 2 cases catch the full numerical range so any value will be satisfied by the 2 cases above.
Regardless, I'll still add an error.
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
2 times, most recently
from
98260c9 to
8e9b450
Compare
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
2 times, most recently
from
3182e35 to
9500e22
Compare
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
from
9500e22 to
8958945
Compare
| // The asset balance of the channel is simply not enough to | ||
| // route the asset units, we report 0 bandwidth in order for the | ||
| // HTLC to fail back. | ||
| return 0, nil | ||
|
|
||
| default: |
There was a problem hiding this comment.
It's should return an error if it ever reaches a point it shouldn't.
To make `PaymentBandwidth` more readable, we separate the main codepaths into helper functions. One is used when we're directly comparing asset units to each other, and the other one is the path that calculates an msat amount based on an RFQ quote.
We now make use of the AuxHtlcView to calculate a more precise value of our local balance. This is using the ComputeView helper in order to manually process HTLC adds from our side, providing us with the correct value of local balance. We also add the DecodedView as a return value of the helper function, but this will only be used in the next commit for verbose logging.
We add a trace log which includes a pretty print of the HTLCs that are part of our local update log.
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
from
8958945 to
3b5aace
Compare
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Description
When
AuxTrafficShaper.PaymentBandwidthis called asynchonously we could previously report the same bandwidth for 2 different HTLCs that are validating whether they can be added to the channel. This could lead to false-positives and payment failures as the latter HTLC should be checked against the correct bandwidth.Instead of always consulting the commitment blob on what the current asset balance is, we now use the existing helper
ComputeViewto get a more precise representation of the asset balance, which is enabled by the new argumentlnwallet.HtlcView.