Skip to content

implement LSPS5 #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

implement LSPS5 #3499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lightning-liquidity/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ categories = ["cryptography::cryptocurrencies"]
default = ["std"]
std = ["lightning/std"]
backtrace = ["dep:backtrace"]
lsps5 = ["minreq", "url"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll want to add an HTTP client dependency here, especially since recently rustls bumped MSRV.

As send_webhook doesn't even return any data, we should be fine just creating an event variant for it and letting the service implement it however they want, no?

Feel free to convert the lsps5 feature to an lsps5 cfg-gate while you're here though, that would allow us to land this before we're sure LSPS5 is fully ready to be shipped.


[dependencies]
lightning = { version = "0.0.124", path = "../lightning", default-features = false }
Expand All @@ -30,6 +31,9 @@ serde = { version = "1.0", default-features = false, features = ["derive", "allo
serde_json = "1.0"
backtrace = { version = "0.3", optional = true }

minreq = { version = "2.11.1", optional = true, features = ["https", "json-using-serde"] }
url = { version = "2.5.0", optional = true, features = ["serde"] }

[dev-dependencies]
lightning = { version = "0.0.124", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.32.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
Expand Down
8 changes: 8 additions & 0 deletions lightning-liquidity/src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
use crate::lsps0;
use crate::lsps1;
use crate::lsps2;
#[cfg(feature = "lsps5")]
use crate::lsps5;
use crate::prelude::{Vec, VecDeque};
use crate::sync::{Arc, Mutex};

Expand Down Expand Up @@ -114,6 +116,12 @@ pub enum Event {
LSPS2Client(lsps2::event::LSPS2ClientEvent),
/// An LSPS2 (JIT Channel) server event.
LSPS2Service(lsps2::event::LSPS2ServiceEvent),
/// An LSPS5 (Webhook Notifications) client event.
#[cfg(feature = "lsps5")]
LSPS5Client(lsps5::event::LSPS5ClientEvent),
/// An LSPS5 (Webhook Notifications) server event.
#[cfg(feature = "lsps5")]
LSPS5Service(lsps5::event::LSPS5ServiceEvent),
}

struct EventFuture {
Expand Down
2 changes: 2 additions & 0 deletions lightning-liquidity/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ pub mod events;
pub mod lsps0;
pub mod lsps1;
pub mod lsps2;
#[cfg(feature = "lsps5")]
pub mod lsps5;
mod manager;
pub mod message_queue;
#[allow(dead_code)]
Expand Down
2 changes: 2 additions & 0 deletions lightning-liquidity/src/lsps0/msgs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ impl TryFrom<LSPSMessage> for LSPS0Message {
LSPSMessage::LSPS0(message) => Ok(message),
LSPSMessage::LSPS1(_) => Err(()),
LSPSMessage::LSPS2(_) => Err(()),
#[cfg(feature = "lsps5")]
LSPSMessage::LSPS5(_) => Err(()),
}
}
}
Expand Down
Loading
Loading