fix!: use libp2p ping instad of kad ping #3074
Merged
+100
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [kad-dht spec](s://github.com./libp2p/specs/tree/master/kad-dht) says: > PING: Deprecated message type replaced by the dedicated ping protocol. Implementations may still handle incoming PING requests for backwards compatibility. Implementations must not actively send PING requests. Switch to using `@libp2p/ping` instead of KAD-DHT `PING` messages to be compliant with the spec. BREAKING CHANGE: `@libp2p/kad-dht` now depends on `@libp2p/ping` - please configure this in your service map
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kad-dht spec says:
Switch to using
@libp2p/pinginstead of KAD-DHTPINGmessages to be compliant with the spec.Incoming KAD-DHT
PINGmessages are still supported.Refs: #3058
Fixes: #3072
BREAKING CHANGE:
@libp2p/kad-dhtnow depends on@libp2p/ping- please configure this in your service mapChange checklist