Skip to content

Update cample to 3.2.0-alpha.49 #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update cample to 3.2.0-alpha.49 #1702

wants to merge 4 commits into from

Conversation

antonmak1
Copy link
Contributor

I decided to look at the benchmark and saw that it was possible to redo the selection of rows. For some reason, I haven’t thought of such an implementation in a year or so 😕

@antonmak1
Copy link
Contributor Author

antonmak1 commented Jun 20, 2024

Wow, how stupid I am. I may not use the data that comes from the component, because in this case it is not necessary to store it. the line does not directly depend on them (but the label does). As a result, an extra loop for 1000 repetitions appeared in the code, and then I wondered what was wrong with the code.

@antonmak1 antonmak1 changed the title Update cample to 3.2.0-alpha.48 Update cample to 3.2.0-alpha.49 Jun 22, 2024
@pawelblaszczyk5
Copy link

I feel like the optimization added with this update fails under this 😃

@antonmak1
Copy link
Contributor Author

antonmak1 commented Jun 24, 2024

@pawelblaszczyk5 Yes, you may be right. I understood where the error in the slow operation of cample’s "select row" is in the code, but it’s better to fix it at the framework level.

@antonmak1 antonmak1 closed this Jun 24, 2024
@antonmak1
Copy link
Contributor Author

@pawelblaszczyk5 Thank you! Yes, it looks like I was in a hurry and did it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants