-
-
Notifications
You must be signed in to change notification settings - Fork 388
Update /generate.py
to handle "thinking" models
#1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
srdas
wants to merge
7
commits into
jupyterlab:main
Choose a base branch
from
srdas:generate_think
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGuinegagne
reviewed
Apr 15, 2025
* add test catching error with empty touched config.json * handle empty touched config.json, passes test * ensure schema file doesn't have duplicated types * pre-commit
JGuinegagne
reviewed
Apr 16, 2025
JGuinegagne
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1315
In models that return an entire chain of thought,
/generate
fails as the notebook file name becomes excessively long, as noted in the issue cited above.The title returned contains all the thinking about the title, including proposed title text buried within qoutes inside the chain of thought (CoT). This modification extracts the suggested title in the CoT and uses it for the title.
The modification also adds a generic failsafe title in case the CoT fails to return a title. For non-CoT LLMs, the code does not pursue this special handling.
To test:
[1] Set chat model provider to
Ollama
and the model tohuggingface.co/lmstudio-community/DeepCoder-14B-Preview-GGUF:Q6_K
[2] Try the following chat command:
/generate write "hi" in the file "allo.txt" in python
(this will take some time to run, as the model works through its process of reflection).As shown:



Result:
Additional tests undertaken:
/generate add two numbers in python
with the same LLM gives the notebook title:Adding Two Numbers in Python - Basic to Advanced.ipynb
./generate write "hi" in the file "allo.txt" in python
generates a title:Write 'hi' to allo.txt.ipynb
. (Here the LLM isdeepseek-chat
with providerOpenRouter
.)