Support resource name and user value for implicit class constructors #4771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
implicit_constr
branch
2 times, most recently
from
e33a2cf to
80f626a
Compare
|
A part is extracted in #4772 |
zherczeg
force-pushed
the
implicit_constr
branch
3 times, most recently
from
eb2151a to
e8123cb
Compare
galpeter
reviewed
Sep 17, 2021
| @@ -138,6 +138,14 @@ main (void) | |||
| parse_options.options = JERRY_PARSE_HAS_USER_VALUE; | |||
| test_parse_function (source_p, &parse_options, true); | |||
|
|
|||
| /* There is no test for ESNEXT, using MODULE instead. */ | |||
| if (jerry_is_feature_enabled (JERRY_FEATURE_MODULE)) | |||
There was a problem hiding this comment.
Module has its own build option. But I think checking the symbol feature would be better as it has the same build option as ESNEXT.
There was a problem hiding this comment.
Ok, on the long run maybe we should replace them with an esnext check
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
implicit_constr
branch
from
e8123cb to
d838af7
Compare
rerobika
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.