change token to TextField in AbstractAccessToken model #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n2ygk please review and let me know if anything needs to change |
fazeelghafoor
changed the title
n2ygk
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks for this!
I made a small wording change to the CHANGELOG to make it more clear why this change is useful.
I also have a question about whether a swappable dependency is needed. I always have trouble understanding how exactly these migrations are supposed to work with swappable models and would like someone else from @jazzband/django-oauth-toolkit to further review this.
- add TokenChecksumField field - update middleware, validators, and views to use token checksums for token retrieval and validation - modified test migrations to include token_checksum field in "sampleaccesstoken" model - add test for token checksum field
Co-authored-by: Alan Crosswell <[email protected]>
for more information, see https://pre-commit.ci
n2ygk
force-pushed
the
feat/add-token-checksum
branch
from
0adb025 to
68e7f9b
Compare
|
@dopry since I see you are actively looking at DOT right now, would you mind reviewing this PR please? |
|
oops my rebase messed up the migrations. will fix it. |
n2ygk
approved these changes
Aug 13, 2024
|
I'm embarrassed to say I've made yet another error. This time I'm running tox locally before pushing! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1412
Description of the Change
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS