Skip to content

Add post_logout_redirect_uris field to application views #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Add post_logout_redirect_uris field to application views #1285

merged 2 commits into from
Jun 13, 2023

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Jun 12, 2023

Description of the Change

These are missing since RP-initiated logout was added.

I added more tests on the applications views

  • check that no posted data is dropped by the form on update and registration views,
  • tests the displayed forms on the detail view.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@tonial tonial requested a review from a team June 12, 2023 09:30
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1285 (184c44c) into master (f28ca84) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
+ Coverage   97.25%   97.30%   +0.04%     
==========================================
  Files          32       32              
  Lines        2005     2005              
==========================================
+ Hits         1950     1951       +1     
+ Misses         55       54       -1     
Impacted Files Coverage Δ
oauth2_provider/views/application.py 100.00% <ø> (+3.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like new functionality that needs to be documented. Please update the docs. See docs related to redirect_uris

Looks like you may want to also update the create_application management command.

@tonial
Copy link
Contributor Author

tonial commented Jun 13, 2023

The management command already allows to specify post_logout_redirect_uris : see here

I've added the new fields in the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants