Support prompt login #1164
Merged
Support prompt login #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 96.87% 96.90% +0.03%
==========================================
Files 31 31
Lines 1794 1812 +18
==========================================
+ Hits 1738 1756 +18
Misses 56 56
Continue to review full report at Codecov.
|
n2ygk
requested changes
May 27, 2022
n2ygk
force-pushed
the
support-prompt-login
branch
from
4ea2ed3 to
3b40102
Compare
Yep makes sense, thanks for the review :) |
Co-authored-by: Alan Crosswell <[email protected]>
n2ygk
force-pushed
the
support-prompt-login
branch
from
12d59e5 to
7427098
Compare
|
darn it, I tried to rebase to fix the CHANGELOG conflict... |
n2ygk
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, thanks for the great library!
Description of the Change
Adds support for
prompt=loginto comply with https://openid.net/specs/openid-connect-core-1_0.html#AuthRequestChecklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS