Hash application client secrets using Django password hashing #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkarman - Thanks for the idea regarding client secret hashing. I've simplified by turning this into a breaking change (migration not reversible) that will always hash the client secret. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 96.58% 96.61% +0.02%
==========================================
Files 32 32
Lines 1787 1801 +14
==========================================
+ Hits 1726 1740 +14
Misses 61 61 ☔ View full report in Codecov by Sentry. |
Andrew-Chen-Wang
requested changes
Jan 23, 2022
…jazzband#1020) Co-authored-by: Alan Crosswell <[email protected]>
Apply suggestions from code review Co-authored-by: Andrew Chen Wang <[email protected]>
n2ygk
force-pushed
the
issue_729/hash_secrets
branch
from
1cf4259 to
b5f6674
Compare
Andrew-Chen-Wang
approved these changes
Jan 25, 2022
flow3d
pushed a commit
to singular-labs/django-oauth-toolkit
that referenced
this pull request
Mar 22, 2022
…nd#1093) * Add ClientSecretField field to use Django password hashing algorithms (jazzband#1020) Co-authored-by: Andrew Chen Wang <[email protected]> Co-authored-by: Peter Karman <[email protected]> Co-authored-by: Andrew Chen Wang <[email protected]>
2 tasks
|
If feels wrong to see "WIP" in the title of a merged PR / to see WIP in a breaking change in the changelog. |
n2ygk
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #729
Description of the Change
Pick up where #1020 left off and simplify to always hash the client_secret using the Django default hasher.
The migration is not reversible as it hashes cleartext application client secrets.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS