Not existing tokens should return 200 within introspection (not 403) #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Sep 21, 2021
auvipy
previously requested changes
Sep 21, 2021
ZuSe
changed the title
n2ygk
requested changes
Dec 22, 2021
There was a problem hiding this comment.
Thanks for this. It looks right but needs the tests fixed. Also, you indicated that CHANGELOG was updated, AUTHORS, etc. but I don't see where you've done that.
The tests looks pretty easy to fix:
E AssertionError: 200 != 401
Please let me know if you can get to this soon as I'm targeting this for the next minor release.
|
I've updated the checklist to indicate correct status of this PR. |
n2ygk
force-pushed
the
fix/introspection
branch
from
c6b6cd4 to
2467913
Compare
n2ygk
approved these changes
Jan 1, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 31 31
Lines 1775 1775
=======================================
Hits 1716 1716
Misses 59 59 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare with https://datatracker.ietf.org/doc/html/rfc7662
Fixes #
Description of the Change
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS